Issue 939773003: - Simplify collection of stack traces. If we determine that a stack

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 939773003: - Simplify collection of stack traces. If we determine that a stack (Closed)

Created:
5 years, 10 months ago by Ivan Posva

Modified:
5 years, 10 months ago

Reviewers:
rmacnak, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Simplify collection of stack traces. If we determine that a stack trace is needed we collect the full stack trace instead of piecing it together as we walk up the stack. R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=43863

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -242 lines)			Patch
M	runtime/lib/stacktrace.cc	View	2 chunks	+3 lines, -27 lines	0 comments	Download
M	runtime/lib/stacktrace.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/exceptions.cc	View	7 chunks	+37 lines, -123 lines	0 comments	Download
M	runtime/vm/object.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+0 lines, -65 lines	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/error_stacktrace_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Ivan Posva

5 years, 10 months ago (2015-02-19 02:19:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r43863 (presubmit successful).