Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 939753002: dart2js: only allocate one closure in 'setupClass' of the new emitter. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: only allocate one closure in 'setupClass' of the new emitter. R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43901

Patch Set 1 #

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 1 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
floitsch
5 years, 10 months ago (2015-02-18 20:38:04 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-02-19 08:13:20 UTC) #3
floitsch
5 years, 10 months ago (2015-02-20 09:10:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43901 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698