Issue 93973002: Add test of Zones for HttpServer and RawSocketServer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93973002: Add test of Zones for HttpServer and RawSocketServer. (Closed)

Created:
7 years ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
Søren Gjesse, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add test of Zones for HttpServer and RawSocketServer. BUG=https://code.google.com/p/dart/issues/detail?id=15367 R=floitsch@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30775

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -6 lines)			Patch
M	runtime/bin/socket_patch.dart	View	1	4 chunks	+8 lines, -6 lines	0 comments	Download
M	tests/standalone/io/http_server_test.dart	View	1	1 chunk	+51 lines, -0 lines	0 comments	Download
M	tests/standalone/io/raw_socket_test.dart	View	1	2 chunks	+53 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

Søren Gjesse

What is the exact purpose of these tests? Checking that the dart:io code does not ...

7 years ago (2013-11-28 07:45:29 UTC) #2

floitsch

LGTM, but as discussed in issue 15367, there needs to be a negative test too, ...

7 years ago (2013-11-28 11:53:18 UTC) #4

Anders Johnsen

7 years ago (2013-11-29 10:26:08 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 manually as r30775 (presubmit successful).