Issue 939643002: Add error handling when initializing the file system watcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 939643002: Add error handling when initializing the file system watcher (Closed)

Created:
5 years, 10 months ago by Søren Gjesse

Modified:
4 years, 4 months ago

Reviewers:
wibling, kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add error handling when initializing the file system watcher R=kustermann@google.com, wibling@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=43838

Patch Set 1 #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -3 lines)			Patch
M	runtime/bin/file_patch.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/file_system_watcher.cc	View	2 chunks	+10 lines, -1 line	1 comment	Download
M	runtime/bin/file_system_watcher_linux.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/939643002/diff/1/runtime/bin/file_system_watcher.cc File runtime/bin/file_system_watcher.cc (right): https://codereview.chromium.org/939643002/diff/1/runtime/bin/file_system_watcher.cc#newcode27 runtime/bin/file_system_watcher.cc:27: Dart_Handle error = DartUtils::NewDartOSError(&os_error); Would it be possible ...

5 years, 10 months ago (2015-02-18 13:10:10 UTC) #2

Søren Gjesse

Committed patchset #1 (id:1) manually as 43838 (presubmit successful).

5 years, 10 months ago (2015-02-18 13:20:23 UTC) #3

Message was sent while issue was closed.

delayed lgtm.

Expand Messages | Collapse Messages