Issue 93933014: Changes for Chrome 32

Issue 93933014: Changes for Chrome 32 (Closed)

Created:
7 years ago by vsm

Modified:
6 years, 11 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Changes for Chrome 32 Once we're ready to switch ... some paths have changed from 31. R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=31486

Patch Set 4 : More fixes for chrome 32/1700 roll #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -17 lines)			Patch
M	pkg/pkg.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/audiobuffersourcenode_test.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	1 2	3 chunks	+8 lines, -7 lines	0 comments	Download
M	tools/dom/scripts/generator.py	View	1 2	4 chunks	+8 lines, -1 line	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	1 2 3	16 chunks	+50 lines, -8 lines	1 comment	Download
M	tools/dom/templates/html/dartium/cpp_callback_header.template	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://chromiumcodereview.appspot.com/93933014/diff/20001/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/93933014/diff/20001/tools/dom/scripts/generator.py#newcode1182 tools/dom/scripts/generator.py:1182: 'SVGRect': TypeData(clazz='SVGTearOff', native_type='SVGPropertyTearOff<SVGRect>'), Drive by comment... the names ...

7 years ago (2013-12-20 19:09:16 UTC) #2

vsm

Committed patchset #4 manually as r31486 (presubmit successful).

6 years, 11 months ago (2014-01-06 17:12:34 UTC) #3

Jacob

6 years, 11 months ago (2014-01-06 17:35:37 UTC) #4

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/93933014/diff/100001/tools/dom/scripts/system...
File tools/dom/scripts/systemnative.py (right):

https://codereview.chromium.org/93933014/diff/100001/tools/dom/scripts/system...
tools/dom/scripts/systemnative.py:204: # FIXME(vsm): Handle ThisValue attribute.
should there be a bug tracking this?

Expand Messages | Collapse Messages