Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 939303003: pkg/unittest: Fix warnings reported by analyzer (Closed)

Created:
5 years, 10 months ago by kevmoo
Modified:
5 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/unittest.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : nits #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -10 lines) Patch
M lib/src/dart.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/isolate_wrapper.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +6 lines, -8 lines 2 comments Download
M test/io.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
kevmoo
5 years, 10 months ago (2015-02-20 04:36:29 UTC) #2
nweiz
Can you update the pubspec to go back to -dev as well?
5 years, 10 months ago (2015-02-20 19:02:53 UTC) #3
kevmoo
PTAL Also updated the min required SDK
5 years, 10 months ago (2015-02-20 19:57:45 UTC) #4
nweiz
lgtm
5 years, 10 months ago (2015-02-20 19:58:41 UTC) #5
kevmoo
Committed patchset #2 (id:20001) manually as d52ed84009eeb7f6bbb9e5997d7f88f652103b9e (presubmit successful).
5 years, 10 months ago (2015-02-20 20:00:49 UTC) #6
nweiz
https://codereview.chromium.org/939303003/diff/20001/pubspec.yaml File pubspec.yaml (left): https://codereview.chromium.org/939303003/diff/20001/pubspec.yaml#oldcode12 pubspec.yaml:12: # properly constraints all features it provides. I missed ...
5 years, 10 months ago (2015-02-23 23:13:43 UTC) #7
kevmoo
5 years, 10 months ago (2015-02-23 23:20:18 UTC) #8
Message was sent while issue was closed. 
https://codereview.chromium.org/939303003/diff/20001/pubspec.yaml
File pubspec.yaml (left):

https://codereview.chromium.org/939303003/diff/20001/pubspec.yaml#oldcode12
pubspec.yaml:12: # properly constraints all features it provides.
On 2015/02/23 23:13:43, nweiz wrote:
> I missed this in the review; why did you get rid of this comment?

Likely a total oversight on my part. The editor nukes comments in Yaml

Powered by Google App Engine
This is Rietveld 408576698