Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 938783003: Don't constant fold operation if result is incompatible with it. (Closed)

Created:
5 years, 10 months ago by Vyacheslav Egorov (Google)
Modified:
5 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't constant fold operation if result is incompatible with it. For example we can't replace BinarySmiOp with Mint constant because we might have removed the checks based on the assumption that BinarySmiOp always returns a Smi. BUG=http://dartbug.com/22480 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=43875

Patch Set 1 #

Patch Set 2 : Work-around quasi-missing deopt environments #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -13 lines) Patch
M runtime/vm/compiler.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 2 chunks +30 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
A + tests/language/vm/regress_22480_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vyacheslav Egorov (Google)
PTAL
5 years, 10 months ago (2015-02-18 19:13:23 UTC) #2
Florian Schneider
https://codereview.chromium.org/938783003/diff/20001/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/938783003/diff/20001/runtime/vm/intermediate_language.cc#newcode1585 runtime/vm/intermediate_language.cc:1585: UNREACHABLE(); Move UNREACHABLE down outside the switch? https://codereview.chromium.org/938783003/diff/20001/runtime/vm/intermediate_language.cc#newcode1638 runtime/vm/intermediate_language.cc:1638: ...
5 years, 10 months ago (2015-02-19 12:03:55 UTC) #3
Florian Schneider
lgtm
5 years, 10 months ago (2015-02-19 13:16:57 UTC) #4
koda
On 2015/02/19 13:16:57, Florian Schneider wrote: > lgtm Please also update corelib.status when hash_set_test starts ...
5 years, 10 months ago (2015-02-19 13:24:20 UTC) #5
Vyacheslav Egorov (Google)
5 years, 10 months ago (2015-02-19 13:48:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as 43875 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698