Issue 93873015: - Remove the reply_port from the VM internal message object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 93873015: - Remove the reply_port from the VM internal message object. (Closed)

Created:
7 years ago by Ivan Posva

Modified:
7 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Remove the reply_port from the VM internal message object. - Adjust all the uses of this API. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31205

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -89 lines)			Patch
M	runtime/bin/vmservice/message.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/vmservice/vmservice.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/vmservice_impl.cc	View	4 chunks	+3 lines, -16 lines	0 comments	Download
M	runtime/lib/isolate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/lib/isolate_patch.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/dart_entry.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/dart_entry.cc	View	2 chunks	+11 lines, -14 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	runtime/vm/message.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	runtime/vm/message_handler.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/message_handler_test.cc	View	8 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/message_test.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/native_api_impl.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/port_test.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/service.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/service.cc	View	3 chunks	+25 lines, -13 lines	0 comments	Download

Total messages: 3 (0 generated)

Ivan Posva

7 years ago (2013-12-17 21:11:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31205 (presubmit successful).