Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 938603003: Classify mirror tests skipped on the VM. (Closed)

Created:
5 years, 10 months ago by rmacnak
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Classify mirror tests skipped on the VM. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=43862

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M tests/lib/lib.status View 1 2 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
5 years, 10 months ago (2015-02-19 01:02:35 UTC) #2
kevmoo
LGTM with one request to explain a SkipByDesign https://codereview.chromium.org/938603003/diff/20001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/938603003/diff/20001/tests/lib/lib.status#newcode244 tests/lib/lib.status:244: mirrors/mirrors_used*: ...
5 years, 10 months ago (2015-02-19 01:06:35 UTC) #3
rmacnak
https://codereview.chromium.org/938603003/diff/20001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/938603003/diff/20001/tests/lib/lib.status#newcode244 tests/lib/lib.status:244: mirrors/mirrors_used*: SkipByDesign # Invalid tests. On 2015/02/19 01:06:35, kevmoo ...
5 years, 10 months ago (2015-02-19 01:13:18 UTC) #5
rmacnak
5 years, 10 months ago (2015-02-19 01:14:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 43862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698