Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 938383005: Extends shortened representation of numbers to negative numbers. (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Extends shortened representation of numbers to negative numbers. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44015

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 2 chunks +31 lines, -30 lines 0 comments Download
M tests/compiler/dart2js/number_output_test.dart View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
I still think this is better with regexps.
5 years, 10 months ago (2015-02-25 01:05:57 UTC) #2
floitsch
LGTM.
5 years, 10 months ago (2015-02-25 01:07:14 UTC) #3
sra1
5 years, 10 months ago (2015-02-25 03:06:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 44015 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698