Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 93823003: Mark timer_test as failing on Dartium. (Closed)

Created:
7 years ago by Lasse Reichstein Nielsen
Modified:
7 years ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark timer_test as failing on Dartium. After removing the 1 ms fiddling factor from the test, it still fails on Dartium. It does not fail on the VM any more, since the timer was fixed, so I'd prefer to not change the test back, since t really does detect an error. The problem is that the timer fires too soon. The difference between a DateTime.now() created before the timer was started, and one created after the time completed, gives a time that is less than the timeout. It may be due to either DateTime.now not being good enough, or the timer firing too early, but it's likely the latter. R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/lib/lib.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years ago (2013-12-11 09:53:34 UTC) #1
Søren Gjesse
lgtm
7 years ago (2013-12-11 10:14:17 UTC) #2
Lasse Reichstein Nielsen
7 years ago (2013-12-11 10:18:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31061 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698