Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 937503002: Fix suggested SDK constraints for the ^ operator. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix suggested SDK constraints for the ^ operator. This gets rid of the suggested prerelease suffix for SDK constraints for pubspecs using the ^ operator, since 1.8.0 itself is out now and probably no one is using a prerelease version of it. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=43823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M sdk/lib/_internal/pub/lib/src/validator/dependency.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/validator/dependency.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 10 months ago (2015-02-17 21:19:17 UTC) #1
Bob Nystrom
LGTM. Is there a test that includes this verbiage that also needs to be updated?
5 years, 10 months ago (2015-02-17 21:31:41 UTC) #2
nweiz
On 2015/02/17 21:31:41, Bob Nystrom wrote: > LGTM. > > Is there a test that ...
5 years, 10 months ago (2015-02-17 21:51:55 UTC) #3
nweiz
5 years, 10 months ago (2015-02-17 21:52:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43823 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698