Add DatastoreDB.replace({defaultPartition})

Add DatastoreDB.replace({defaultPartition})

R=sgjesse@google.com

Committed: https://github.com/dart-lang/gcloud/commit/65ac2b01d510b83d7ff716a2bc44455cfd984605

[kustermann, 2015-02-19 11:25:31]

kustermann@google.com changed reviewers:
+ sgjesse@google.com

[Søren Gjesse, 2015-02-19 11:59:51]

https://codereview.chromium.org/937133002/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/937133002/diff/1/CHANGELOG.md#newcode4
CHANGELOG.md:4: 
Could you add an entry for 0.1.3+2 (I  forgot that), something like this:

* Increased version constraint on googleapis and googleapis_beta.

https://codereview.chromium.org/937133002/diff/1/lib/src/db/db.dart
File lib/src/db/db.dart (right):

https://codereview.chromium.org/937133002/diff/1/lib/src/db/db.dart#newcode333
lib/src/db/db.dart:333: DatastoreDB replace({Partition defaultPartition}) {
The method name 'replace' seems somewhat overloaded with operation you would
expect on a DatastoreDB instance. How about changing this to a DatastoreDB.from
constructor?

var existingDb = ...
var otherDb = new DatastoreDB.from(existingDb, defaultPartition: ...);

https://codereview.chromium.org/937133002/diff/1/test/db/db_test.dart
File test/db/db_test.dart (right):

https://codereview.chromium.org/937133002/diff/1/test/db/db_test.dart#newcode33
test/db/db_test.dart:33: var db = new DatastoreDB(null);
Maybe duplicate this test with:

var nsDb = new DatastoreDB(null, defaultPartition: new
Partition('foobar-namespace'));

[kustermann, 2015-02-19 12:17:11]

PTAL

https://codereview.chromium.org/937133002/diff/1/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/937133002/diff/1/CHANGELOG.md#newcode4
CHANGELOG.md:4: 
On 2015/02/19 11:59:51, Søren Gjesse wrote:
> Could you add an entry for 0.1.3+2 (I  forgot that), something like this:
> 
> * Increased version constraint on googleapis and googleapis_beta.

Done. Used:

* Widened googleapis/googleapis_beta constraints in pubspec.yaml.

https://codereview.chromium.org/937133002/diff/1/lib/src/db/db.dart
File lib/src/db/db.dart (right):

https://codereview.chromium.org/937133002/diff/1/lib/src/db/db.dart#newcode333
lib/src/db/db.dart:333: DatastoreDB replace({Partition defaultPartition}) {
On 2015/02/19 11:59:51, Søren Gjesse wrote:
> The method name 'replace' seems somewhat overloaded with operation you would
> expect on a DatastoreDB instance. How about changing this to a
DatastoreDB.from
> constructor?
> 
> var existingDb = ...
> var otherDb = new DatastoreDB.from(existingDb, defaultPartition: ...);

Another constructor is of no value, since the existing one can do that as well.

Removed replace method now.

https://codereview.chromium.org/937133002/diff/1/test/db/db_test.dart
File test/db/db_test.dart (right):

https://codereview.chromium.org/937133002/diff/1/test/db/db_test.dart#newcode33
test/db/db_test.dart:33: var db = new DatastoreDB(null);
On 2015/02/19 11:59:51, Søren Gjesse wrote:
> Maybe duplicate this test with:
> 
> var nsDb = new DatastoreDB(null, defaultPartition: new
> Partition('foobar-namespace'));

No need to duplicate it now, since I've removed the replace method.

[Søren Gjesse, 2015-02-19 12:34:41]

lgtm

[kustermann, 2015-02-19 12:36:43]

Committed patchset #2 (id:20001) manually as
65ac2b01d510b83d7ff716a2bc44455cfd984605 (presubmit successful).