Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 936733004: Add README file to the mime package (Closed)

Created:
5 years, 10 months ago by Søren Gjesse
Modified:
5 years, 10 months ago
Reviewers:
wibling, kustermann
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add README file to the mime package Also update CHANGELOG after last change. R=kustermann@google.com, wibling@google.com BUG=http://dartbug.com/22442 Committed: https://code.google.com/p/dart/source/detail?r=43841

Patch Set 1 #

Total comments: 18

Patch Set 2 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -0 lines) Patch
M pkg/mime/CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/mime/README.md View 1 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Søren Gjesse
5 years, 10 months ago (2015-02-18 10:11:51 UTC) #1
kustermann
lgtm
5 years, 10 months ago (2015-02-18 12:40:23 UTC) #2
wibling
https://codereview.chromium.org/936733004/diff/1/pkg/mime/CHANGELOG.md File pkg/mime/CHANGELOG.md (right): https://codereview.chromium.org/936733004/diff/1/pkg/mime/CHANGELOG.md#newcode3 pkg/mime/CHANGELOG.md:3: * Fixed erroneous behavior for listening and when pause/resume ...
5 years, 10 months ago (2015-02-18 13:44:46 UTC) #3
Søren Gjesse
Thanks for the review. https://codereview.chromium.org/936733004/diff/1/pkg/mime/CHANGELOG.md File pkg/mime/CHANGELOG.md (right): https://codereview.chromium.org/936733004/diff/1/pkg/mime/CHANGELOG.md#newcode3 pkg/mime/CHANGELOG.md:3: * Fixed erroneous behavior for ...
5 years, 10 months ago (2015-02-18 14:44:18 UTC) #4
Søren Gjesse
5 years, 10 months ago (2015-02-18 14:45:37 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43841 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698