Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 936613007: Default to compact Map/Set implementation. (Closed)

Created:
5 years, 10 months ago by koda
Modified:
5 years, 10 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Default to compact Map/Set implementation. Also adjust unit tests accoringly to maintain coverage, and remove some redundant ones. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43894

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -326 lines) Patch
M runtime/lib/linked_hash_map.cc View 1 chunk +1 line, -1 line 0 comments Download
D tests/corelib/hash_map2_internal_test.dart View 1 1 chunk +0 lines, -293 lines 0 comments Download
M tests/corelib/hash_map2_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
D tests/corelib/hash_map_internal_test.dart View 1 1 chunk +0 lines, -27 lines 0 comments Download
M tests/corelib/hash_map_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/corelib/hash_set_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
5 years, 10 months ago (2015-02-18 20:21:57 UTC) #1
Ivan Posva
LGTM -ip
5 years, 10 months ago (2015-02-19 01:23:03 UTC) #2
koda
5 years, 10 months ago (2015-02-19 21:29:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r43894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698