Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 936283005: VM: Fix a bug with local variable values when breaking at a variable declaration. (Closed)

Created:
5 years, 10 months ago by Florian Schneider
Modified:
5 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Fix a bug with local variable values when breaking at a variable declaration. This fixes the case When breaking at a declaration 'var a;' BUG=dartbug.com/22353 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=43882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -2 lines) Patch
M runtime/vm/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/debugger/local_variables_test.dart View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 10 months ago (2015-02-19 11:03:22 UTC) #2
hausner
Very nice and simple. Thank you! LGTM.
5 years, 10 months ago (2015-02-19 16:37:32 UTC) #3
Florian Schneider
5 years, 10 months ago (2015-02-19 17:11:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698