Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 935923002: Re-add minified/unminified tests. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/matcher@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-add minified/unminified tests. These were mistakenly moved to unittest along with some throws* matcher tests, but they test matchers in the matcher package. R=kevmoo@google.com Committed: https://github.com/dart-lang/matcher/commit/9f15e52a2674a095c57cab2772f65bc2e59c5f7e

Patch Set 1 #

Total comments: 6

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -2 lines) Patch
M .status View 1 chunk +2 lines, -2 lines 0 comments Download
A test/minified_test.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download
M test/test_utils.dart View 1 2 chunks +51 lines, -0 lines 0 comments Download
A test/unminified_test.dart View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
5 years, 10 months ago (2015-02-18 03:27:08 UTC) #1
kevmoo
LGTM – if you add the missing imports :-) https://codereview.chromium.org/935923002/diff/1/test/minified_test.dart File test/minified_test.dart (right): https://codereview.chromium.org/935923002/diff/1/test/minified_test.dart#newcode11 test/minified_test.dart:11: ...
5 years, 10 months ago (2015-02-18 04:11:09 UTC) #2
nweiz
Code review changes
5 years, 10 months ago (2015-02-19 00:30:50 UTC) #4
nweiz
https://codereview.chromium.org/935923002/diff/1/test/minified_test.dart File test/minified_test.dart (right): https://codereview.chromium.org/935923002/diff/1/test/minified_test.dart#newcode11 test/minified_test.dart:11: import 'package:unittest/unittest.dart'; On 2015/02/18 04:11:08, kevmoo wrote: > Need ...
5 years, 10 months ago (2015-02-19 00:31:08 UTC) #5
nweiz
5 years, 10 months ago (2015-02-19 00:31:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9f15e52a2674a095c57cab2772f65bc2e59c5f7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698