Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 934603003: Add properties to the element tree (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson
Modified:
5 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add missed file #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -126 lines) Patch
M pkg/analysis_server/lib/src/status/ast_writer.dart View 3 chunks +50 lines, -107 lines 2 comments Download
M pkg/analysis_server/lib/src/status/element_writer.dart View 2 chunks +132 lines, -19 lines 2 comments Download
A pkg/analysis_server/lib/src/status/tree_writer.dart View 1 1 chunk +136 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 3 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
5 years, 10 months ago (2015-02-16 18:46:37 UTC) #2
scheglov
LGTM https://codereview.chromium.org/934603003/diff/20001/pkg/analysis_server/lib/src/status/ast_writer.dart File pkg/analysis_server/lib/src/status/ast_writer.dart (right): https://codereview.chromium.org/934603003/diff/20001/pkg/analysis_server/lib/src/status/ast_writer.dart#newcode117 pkg/analysis_server/lib/src/status/ast_writer.dart:117: properties['static element'] =node.staticElement; Format before commit? https://codereview.chromium.org/934603003/diff/20001/pkg/analysis_server/lib/src/status/element_writer.dart File ...
5 years, 10 months ago (2015-02-16 21:20:29 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/934603003/diff/20001/pkg/analysis_server/lib/src/status/ast_writer.dart File pkg/analysis_server/lib/src/status/ast_writer.dart (right): https://codereview.chromium.org/934603003/diff/20001/pkg/analysis_server/lib/src/status/ast_writer.dart#newcode117 pkg/analysis_server/lib/src/status/ast_writer.dart:117: properties['static element'] =node.staticElement; Done https://codereview.chromium.org/934603003/diff/20001/pkg/analysis_server/lib/src/status/element_writer.dart File pkg/analysis_server/lib/src/status/element_writer.dart (right): https://codereview.chromium.org/934603003/diff/20001/pkg/analysis_server/lib/src/status/element_writer.dart#newcode12 ...
5 years, 10 months ago (2015-02-16 21:41:35 UTC) #4
Brian Wilkerson
5 years, 10 months ago (2015-02-16 21:42:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43801 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698