Issue 93433007: Implement hashCode for classes with equals().

Issue 93433007: Implement hashCode for classes with equals(). (Closed)

Created:
7 years ago by scheglov

Modified:
7 years ago

Reviewers:
devoncarew, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement hashCode for classes with equals(). These problems were reported by dart2js. R=brianwilkerson@google.com, devoncarew@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31068

Patch Set 1 #

Total comments: 4

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -3 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/PropertyAccessorElementImpl.java	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/BottomTypeImpl.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java	View	1 chunk	+6 lines, -1 line	2 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/VoidTypeImpl.java	View	1 chunk	+5 lines, -0 lines	2 comments	Download
M	editor/util/plugins/com.google.dart.java2dart/resources/java_engine.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	4 chunks	+9 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/java_engine.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/analyzer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/93433007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java (right): https://codereview.chromium.org/93433007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java#newcode57 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java:57: return 0; Might be good to give it ...

7 years ago (2013-12-11 03:21:42 UTC) #2

scheglov

7 years ago (2013-12-11 16:34:04 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/93433007/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java
(right):

https://codereview.chromium.org/93433007/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java:57:
return 0;
On 2013/12/11 03:21:43, Brian Wilkerson wrote:
> Might be good to give it a different hashCode than bottom (such as 1).

Done.

https://codereview.chromium.org/93433007/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/VoidTypeImpl.java
(right):

https://codereview.chromium.org/93433007/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/VoidTypeImpl.java:56:
return 0;
On 2013/12/11 03:21:43, Brian Wilkerson wrote:
> Might be good to give it a unique hash code, such as 2.

Done.

Expand Messages | Collapse Messages