VM: Fix issue with local variable values reported by the debugger.

VM: Fix issue with local variable values reported by the debugger.

I added a function to test if a variable is visible or not to the
debugger tests.

BUG=dartbug.com/22353
TEST=standalone/debugger/local_variables_test
R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43850

[Florian Schneider, 2015-02-18 18:08:42]

fschneider@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-02-18 18:32:29]

LGTM.

Nice fix, thank you!

https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugge...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugge...
tests/standalone/debugger/debug_lib.dart:337: MatchLocals(Map localValues, [int
frame_index = 0]) {
It doesn't look like you are using MatchLocals with a frame index anywhere. It's
nice to have this functionality, but for consistency I would prefer if the
frame_index was the first parameter, like in MatchFrame above. Since you are not
using it now, you could just remove the second parameter so you don't have to
fix the other tests.

https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugge...
tests/standalone/debugger/debug_lib.dart:342: class InvertedLocalsMatcher
extends Command {
Would you mind adding a one-liner comment what this matcher is good for? It
seems less intuitive than other matcher names.

[Florian Schneider, 2015-02-18 18:44:44]

New patchsets have been uploaded after l-g-t-m from hausner@google.com

[Florian Schneider, 2015-02-18 18:45:23]

https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugge...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugge...
tests/standalone/debugger/debug_lib.dart:337: MatchLocals(Map localValues, [int
frame_index = 0]) {
On 2015/02/18 18:32:29, hausner wrote:
> It doesn't look like you are using MatchLocals with a frame index anywhere.
It's
> nice to have this functionality, but for consistency I would prefer if the
> frame_index was the first parameter, like in MatchFrame above. Since you are
not
> using it now, you could just remove the second parameter so you don't have to
> fix the other tests.
> 

Yes, I only used to while testing. I'll remove it for now.

https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugge...
tests/standalone/debugger/debug_lib.dart:342: class InvertedLocalsMatcher
extends Command {
On 2015/02/18 18:32:28, hausner wrote:
> Would you mind adding a one-liner comment what this matcher is good for? It
> seems less intuitive than other matcher names.

Added comment and renamed to AssertLocalsNotVisibleMatcher - I could not find a
different descriptive short name.

[Florian Schneider, 2015-02-18 18:48:06]

Committed patchset #3 (id:40001) manually as r43850 (presubmit successful).