Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 933253003: VM: Fix issue with local variable values reported by the debugger. (Closed)

Created:
5 years, 10 months ago by Florian Schneider
Modified:
5 years, 10 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Fix issue with local variable values reported by the debugger. I added a function to test if a variable is visible or not to the debugger tests. BUG=dartbug.com/22353 TEST=standalone/debugger/local_variables_test R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=43850

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -13 lines) Patch
M runtime/platform/assert.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 1 4 chunks +7 lines, -3 lines 0 comments Download
M runtime/vm/parser_test.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A tests/standalone/debugger/local_variables_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
5 years, 10 months ago (2015-02-18 18:08:43 UTC) #2
hausner
LGTM. Nice fix, thank you! https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugger/debug_lib.dart#newcode337 tests/standalone/debugger/debug_lib.dart:337: MatchLocals(Map localValues, [int frame_index ...
5 years, 10 months ago (2015-02-18 18:32:29 UTC) #3
Florian Schneider
https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/933253003/diff/20001/tests/standalone/debugger/debug_lib.dart#newcode337 tests/standalone/debugger/debug_lib.dart:337: MatchLocals(Map localValues, [int frame_index = 0]) { On 2015/02/18 ...
5 years, 10 months ago (2015-02-18 18:45:23 UTC) #5
Florian Schneider
5 years, 10 months ago (2015-02-18 18:48:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r43850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698