Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 933193002: - Increase the size of the preallocated stack trace to give (Closed)

Created:
5 years, 10 months ago by Ivan Posva
Modified:
5 years, 10 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fixes http://dartbug.com/22305 - Increase the size of the preallocated stack trace to give more context in the case of stack overflow. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=43867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Ivan Posva
5 years, 10 months ago (2015-02-18 07:21:55 UTC) #2
siva
lgtm
5 years, 10 months ago (2015-02-19 04:59:42 UTC) #3
Ivan Posva
5 years, 10 months ago (2015-02-19 05:16:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r43867 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698