Addition of the --no-index flag to the analysis server spec.

Addition of the --no-index flag to the analysis server spec.

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43816

[jwren, 2015-02-17 17:43:54]

jwren@google.com changed reviewers:
+ scheglov@google.com

[jwren, 2015-02-17 17:43:55]

I did not increment the spec version, but it should be when the work is done in
the analysis server.

[scheglov, 2015-02-17 17:48:36]

lgtm

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:172: refactoring calls, code
completions and searching.
Would be nice to document also corresponding API requests and state that they
return this error if no index was generated. So, we would remind users that this
API might not work.

[jwren, 2015-02-17 17:54:41]

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:172: refactoring calls, code
completions and searching.
On 2015/02/17 17:48:36, scheglov wrote:
> Would be nice to document also corresponding API requests and state that they
> return this error if no index was generated. So, we would remind users that
this
> API might not work.

Agreed.  After we know what the set of APIs are, I'll go through and do this.

[Brian Wilkerson, 2015-02-17 17:54:46]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-02-17 17:54:46]

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
File pkg/analysis_server/tool/spec/spec_input.html (right):

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:168: An indication that no indexer
calls will be made to the analysis server,
"An indication" seems a little weak. The flag explicitly tells server not to
create an index.

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:170: used that requires an index,
then an <tt>NO_INDEX_GENERATED</tt> exception
"an" --> "a"
"exception" --> "error"

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:172: refactoring calls, code
completions and searching.
I think we need to actually include this information in each individual request
that can generate this error. Otherwise (a) it's hard for clients to remember
which calls will generate the error and (b) the list will get out of date.

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:3111: An "analysis.updateContent"
request contained a
I don't think we quote request/notification names elsewhere. We should be
consistent.

https://codereview.chromium.org/932883002/diff/1/pkg/analysis_server/tool/spe...
pkg/analysis_server/tool/spec/spec_input.html:3132: The "--no-index" flag was
passed when the analysis server created,
"server created" --> "server was created"

[jwren, 2015-02-17 17:55:11]

Committed patchset #1 (id:1) manually as 43816 (presubmit successful).