Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 932093004: Add loose parsing option for dates, accepting mixed case and missing delimiters (Closed)

Created:
5 years, 10 months ago by Alan Knight
Modified:
5 years, 9 months ago
Reviewers:
Chris Bracken
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/intl.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add loose parsing option for dates, accepting mixed case and missing delimiters BUG= R=cbracken@google.com Committed: https://github.com/dart-lang/intl/commit/d8866bd14570ebfaa4317ca6a55dfafd02031645

Patch Set 1 #

Patch Set 2 : Add "loose" parsing for DateTime formats #

Patch Set 3 : Fix test that wasn't checking for exception #

Unified diffs Side-by-side diffs Delta from patch set Stats (+259 lines, -3 lines) Patch
M CHANGELOG.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
M lib/src/intl/date_format.dart View 1 1 chunk +52 lines, -0 lines 0 comments Download
M lib/src/intl/date_format_field.dart View 6 chunks +143 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
A test/date_time_loose_parsing_test.dart View 1 2 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
5 years, 9 months ago (2015-03-07 00:14:28 UTC) #2
Chris Bracken
lgtm
5 years, 9 months ago (2015-03-13 18:10:31 UTC) #3
Alan Knight
5 years, 9 months ago (2015-03-16 23:04:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d8866bd14570ebfaa4317ca6a55dfafd02031645 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698