Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 932053002: Support for interpolated declarations in the js parser. (Closed)

Created:
5 years, 10 months ago by sigurdm
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, sra1
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support for interpolated declarations in the js parser. Also use this support to avoid non-constant templates in async_rewrite. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43837

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -87 lines) Patch
M pkg/compiler/lib/src/js/builder.dart View 6 chunks +29 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/js/nodes.dart View 9 chunks +34 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js/printer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 18 chunks +90 lines, -54 lines 0 comments Download
M pkg/compiler/lib/src/js/template.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/js_parser_statements_test.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sigurdm
5 years, 10 months ago (2015-02-18 08:37:45 UTC) #3
floitsch
LGTM. https://chromiumcodereview.appspot.com/932053002/diff/20001/pkg/compiler/lib/src/js/rewrite_async.dart File pkg/compiler/lib/src/js/rewrite_async.dart (right): https://chromiumcodereview.appspot.com/932053002/diff/20001/pkg/compiler/lib/src/js/rewrite_async.dart#newcode630 pkg/compiler/lib/src/js/rewrite_async.dart:630: "thenHelper": isAsync ? asyncHelper : streamHelper, s/thenHelper/runtimeHelper/ ? ...
5 years, 10 months ago (2015-02-18 12:28:14 UTC) #4
sigurdm
Committed patchset #2 (id:40001) manually as 43837 (presubmit successful).
5 years, 10 months ago (2015-02-18 13:00:51 UTC) #6
sigurdm
5 years, 10 months ago (2015-02-18 13:03:09 UTC) #7
Message was sent while issue was closed. 
https://chromiumcodereview.appspot.com/932053002/diff/20001/pkg/compiler/lib/...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://chromiumcodereview.appspot.com/932053002/diff/20001/pkg/compiler/lib/...
pkg/compiler/lib/src/js/rewrite_async.dart:630: "thenHelper": isAsync ?
asyncHelper : streamHelper,
On 2015/02/18 12:28:13, floitsch wrote:
> s/thenHelper/runtimeHelper/ ?

Done.

https://chromiumcodereview.appspot.com/932053002/diff/20001/pkg/compiler/lib/...
pkg/compiler/lib/src/js/rewrite_async.dart:892: var #self= this;
On 2015/02/18 12:28:14, floitsch wrote:
> missing space

Done.

https://chromiumcodereview.appspot.com/932053002/diff/20001/pkg/compiler/lib/...
pkg/compiler/lib/src/js/rewrite_async.dart:1866: new
js.ArrayInitializer(enclosingFinallyLabels.map(js.number)
On 2015/02/18 12:28:13, floitsch wrote:
> I would break at the "enclosingFinallyLabels".

Done.

https://chromiumcodereview.appspot.com/932053002/diff/20001/tests/compiler/da...
File tests/compiler/dart2js/js_parser_statements_test.dart (right):

https://chromiumcodereview.appspot.com/932053002/diff/20001/tests/compiler/da...
tests/compiler/dart2js/js_parser_statements_test.dart:329: testStatement('var #
= 3', ['x'], 'var x = 3;'),
On 2015/02/18 12:28:14, floitsch wrote:
> Add tests with "new js.Declaration".

Done.

Powered by Google App Engine
This is Rietveld 408576698