Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 931953002: Move js_ast library to its own package under pkg (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, Jennifer Messerly
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move js_ast library to its own package under pkg IT IS NECESSARY TO REBUILD AFTER SYNCING TO THIS CL. Rebuilding creates a needed symlink in out/... for the new js_ast package. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=44012

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4632 lines) Patch
D pkg/compiler/lib/src/js/builder.dart View 1 chunk +0 lines, -1336 lines 0 comments Download
D pkg/compiler/lib/src/js/characters.dart View 1 chunk +0 lines, -117 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 chunk +2 lines, -3 lines 0 comments Download
D pkg/compiler/lib/src/js/js_ast.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/compiler/lib/src/js/nodes.dart View 1 chunk +0 lines, -1148 lines 0 comments Download
D pkg/compiler/lib/src/js/precedence.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D pkg/compiler/lib/src/js/printer.dart View 1 chunk +0 lines, -1247 lines 0 comments Download
D pkg/compiler/lib/src/js/template.dart View 1 chunk +0 lines, -739 lines 0 comments Download
A + pkg/js_ast/LICENSE View 1 chunk +1 line, -1 line 0 comments Download
A pkg/js_ast/README.md View 1 chunk +4 lines, -0 lines 0 comments Download
A + pkg/js_ast/lib/js_ast.dart View 1 chunk +6 lines, -6 lines 0 comments Download
A + pkg/js_ast/lib/src/builder.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/js_ast/lib/src/characters.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/js_ast/lib/src/nodes.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/js_ast/lib/src/precedence.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/js_ast/lib/src/printer.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/js_ast/lib/src/template.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/js_ast/pubspec.yaml View 1 chunk +3 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (1 generated)
sra1
5 years, 10 months ago (2015-02-18 05:51:51 UTC) #2
floitsch
LGTM. Please send a mail to dart2js-team to remind to rebuild. https://codereview.chromium.org/931953002/diff/20001/pkg/js_ast/pubspec.yaml File pkg/js_ast/pubspec.yaml (right): ...
5 years, 10 months ago (2015-02-18 16:37:52 UTC) #3
sra1
5 years, 10 months ago (2015-02-25 01:27:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 44012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698