Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 931283006: Delete IterableMixinWorkaround (Closed)

Created:
5 years, 10 months ago by sra1
Modified:
5 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Delete IterableMixinWorkaround Most code in IterableMixinWorkaround was unused. The remaining O(20) methods have been moved to their only use on JSArray. I looked into using ListMixin on JSArray. The code was clearly worse - nearly 1% bloat on swarm and some less precise inference. I think it is reasonable to have the JSArray methods special-cased for performance reasons. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=44006

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -435 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +0 lines, -1 line 1 comment Download
M sdk/lib/_internal/compiler/js_lib/js_array.dart View 8 chunks +186 lines, -36 lines 0 comments Download
M sdk/lib/internal/iterable.dart View 1 chunk +0 lines, -398 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
sra1
https://codereview.chromium.org/931283006/diff/1/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (left): https://codereview.chromium.org/931283006/diff/1/pkg/compiler/lib/src/js_backend/backend.dart#oldcode91 pkg/compiler/lib/src/js_backend/backend.dart:91: 'IterableMixinWorkaround': const <String>['forEach'], We should possibly remove this hack ...
5 years, 10 months ago (2015-02-24 04:04:53 UTC) #2
Lasse Reichstein Nielsen
LGTM!!! Still duplicates some functionality of ListBase which would be better reused (but I see ...
5 years, 10 months ago (2015-02-24 12:34:24 UTC) #3
sra1
5 years, 10 months ago (2015-02-24 22:57:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 44006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698