Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 931113006: Remove --old_gen_heap_size from the pub scripts. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove --old_gen_heap_size from the pub scripts. This was added because it used to be necessary to load dart2js, but dart2js itself no longer uses it and it's limiting the VM's overall ability to allocate memory. R=rnystrom@google.com BUG=22413 Committed: https://code.google.com/p/dart/source/detail?r=43821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M sdk/bin/pub View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/bin/pub.bat View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 10 months ago (2015-02-17 20:33:14 UTC) #1
Bob Nystrom
lgtm
5 years, 10 months ago (2015-02-17 21:05:18 UTC) #2
nweiz
5 years, 10 months ago (2015-02-17 21:46:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43821 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698