Issue 930143002: Remove implicit dependencies.

Issue 930143002: Remove implicit dependencies. (Closed)

Created:
5 years, 10 months ago by ahe

Modified:
3 years, 11 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove implicit dependencies. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43874

Patch Set 2 : Issues found with unit tests. #

Total comments: 1

Patch Set 3 : Changes committed as r43874. #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -16 lines)			Patch
M	dart/pkg/compiler/lib/src/compiler.dart	View		4 chunks	+3 lines, -12 lines	0 comments	Download
M	dart/pkg/compiler/lib/src/dart_backend/backend.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	dart/pkg/compiler/lib/src/js_backend/backend.dart	View	1 2	2 chunks	+12 lines, -0 lines	0 comments	Download
M	dart/pkg/compiler/lib/src/resolution/members.dart	View		1 chunk	+11 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js/mock_libraries.dart	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ahe

PTAL https://codereview.chromium.org/930143002/diff/20001/dart/pkg/compiler/lib/src/js_backend/backend.dart File dart/pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/930143002/diff/20001/dart/pkg/compiler/lib/src/js_backend/backend.dart#newcode956 dart/pkg/compiler/lib/src/js_backend/backend.dart:956: interceptorsLibrary.findLocal('JSUInt31'), registry); I have an hypothesis: the ++ ...

5 years, 10 months ago (2015-02-18 16:30:56 UTC) #5

ahe

5 years, 10 months ago (2015-02-19 13:31:48 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 43874 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages