Use a pool to restrict access to file descriptors in pub.

Use a pool to restrict access to file descriptors in pub.

R=rnystrom@google.com
BUG=15358
Committed: https://code.google.com/p/dart/source/detail?r=30830

[Bob Nystrom, 2013-12-02 20:36:43]

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:31: final _fdPool = new Pool(32);
I know "FD" is a common acronym here, but it still rubs me the wrong way. How
about "file" or "descriptor"?

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:498: Future<PubProcessResult>
runProcess(String executable, List<String> args,
Now that dart:io has sync processes, can any of this be converted to sync code?
The tar stuff probably still needs to be async, but we could probably make some
of the git calls sync.

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pool.dart (right):

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pool.dart:12: /// Manages an abstract pool of
resources with a limit on how many may be in use
Add a TODO comment to put this somewhere so we don't have to copy it into
multiple packages.

[nweiz, 2013-12-03 21:44:03]

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/io.dart (right):

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:31: final _fdPool = new Pool(32);
On 2013/12/02 20:36:43, Bob Nystrom wrote:
> I know "FD" is a common acronym here, but it still rubs me the wrong way. How
> about "file" or "descriptor"?

Done.

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/io.dart:498: Future<PubProcessResult>
runProcess(String executable, List<String> args,
On 2013/12/02 20:36:43, Bob Nystrom wrote:
> Now that dart:io has sync processes, can any of this be converted to sync
code?
> The tar stuff probably still needs to be async, but we could probably make
some
> of the git calls sync.

We could probably make a couple of git calls synchronous, but I think we want
the ones used by GitSource to stay async, since the source APIs need to be async
anyway. Those make up so many of the git commands I don't think it makes sense
to add infrastructure so that the few remaining ones are synchronous.

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/pool.dart (right):

https://codereview.chromium.org/93013002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/pool.dart:12: /// Manages an abstract pool of
resources with a limit on how many may be in use
On 2013/12/02 20:36:43, Bob Nystrom wrote:
> Add a TODO comment to put this somewhere so we don't have to copy it into
> multiple packages.

Done.

[Bob Nystrom, 2013-12-03 22:25:11]

lgtm

[nweiz, 2013-12-03 22:31:06]

Committed patchset #2 manually as r30830 (presubmit successful).