Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 930093002: Support positional optional parameters even if stubs are missing. (Closed)

Created:
5 years, 10 months ago by herhut
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support positional optional parameters even if stubs are missing. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 chunk +15 lines, -4 lines 0 comments Download
A tests/corelib/apply4_test.dart View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
herhut
5 years, 10 months ago (2015-02-16 15:24:34 UTC) #1
floitsch
LGTM.
5 years, 10 months ago (2015-02-16 16:05:52 UTC) #2
herhut
5 years, 10 months ago (2015-02-17 09:39:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698