Issue 929883005: - Leave abstract class StackTrace be an abstract class and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 929883005: - Leave abstract class StackTrace be an abstract class and (Closed)

Created:
5 years, 10 months ago by Ivan Posva

Modified:
5 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

- Leave abstract class StackTrace be an abstract class and implement its interface from within the VM instead of patching. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=43803

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -14 lines)			Patch
A +	runtime/lib/stacktrace.dart	View	1 chunk	+2 lines, -3 lines	0 comments	Download
D	runtime/lib/stacktrace_patch.dart	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/symbols.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Ivan Posva

5 years, 10 months ago (2015-02-16 23:49:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r43803 (presubmit successful).