Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 929503004: dart2js: Don't emit fields that are named "eval" or "arguments". (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
zarah, herhut
CC:
reviews_dartlang.org, sra1, zarah
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Don't emit fields that are named "eval" or "arguments". R=zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=43961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -1 line) Patch
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +6 lines, -1 line 0 comments Download
A tests/compiler/dart2js/use_strict_test.dart View 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
floitsch
5 years, 10 months ago (2015-02-20 20:10:24 UTC) #2
zarah
LGTM
5 years, 10 months ago (2015-02-23 08:09:17 UTC) #4
floitsch
5 years, 10 months ago (2015-02-23 16:24:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698