Add SemanticVisitor to dart2js.

Add SemanticVisitor to dart2js.

BUG=
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44393

[Johnni Winther, 2015-02-20 14:41:14]

johnniwinther@google.com changed reviewers:
+ karlklose@google.com

[Johnni Winther, 2015-02-20 14:41:15]

https://codereview.chromium.org/929113002/diff/100001/tests/compiler/dart2js/...
File tests/compiler/dart2js/semantic_visitor_test.dart (right):

https://codereview.chromium.org/929113002/diff/100001/tests/compiler/dart2js/...
tests/compiler/dart2js/semantic_visitor_test.dart:1979:
visitClassTypeLiteralInvoke(Send node, ClassElement element, NodeList arguments,
Selector selector, arg) {
Generated long lines. Will Fix.

[karlklose, 2015-02-25 12:39:39]

LGTM so far.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/access_semantics.dart (right):

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:22: /**
Please use '///' to make the comments more compact.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:27: 
I think we should split LOCAL_FUNCTION, LOCAL_VARIABLE and PARAMETER into two
cases each:
  LOCAL_xxx for a reference to a definition in the current context, and
  LOCAL_xxx for a reference to a definition in an outer context.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:217: * class in which
[identifier] should be looked up.  Null if the expression
'[Null]' or '`null`'?

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:1593: R visitLazyAnd(
Why not logical and?

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:1647: /// [receiver] whose
getter and setter are½ defined by [getterSelector] and
I think they are fully defined!

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2538: /// Postfix
expression with [operator] reading from a static [method], that is,
long line.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2613: /// Postfix
expression with [operator] reading from the super field [readField]
Long line.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2634: /// Postfix
expression with [operator] reading from a super [field] and writing
Long line.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2715: /// Postfix
expression with [operator] on a type literal for a class [element].
Long line.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/send_structure.dart (right):

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/send_structure.dart:15: abstract class
SendStructure<R, A> {
Please add documentation for this class hierarchy.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/send_structure.dart:263: // This is not a valid
case.
Shouldn't these cases throw too?

[Johnni Winther, 2015-03-04 11:56:41]

Patchset #7 (id:120001) has been deleted

[Johnni Winther, 2015-03-04 11:59:39]

PTAL, now ready for commit.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/access_semantics.dart (right):

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:22: /**
On 2015/02/25 12:39:38, karlklose wrote:
> Please use '///' to make the comments more compact.

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:27: 
On 2015/02/25 12:39:38, karlklose wrote:
> I think we should split LOCAL_FUNCTION, LOCAL_VARIABLE and PARAMETER into two
> cases each:
>   LOCAL_xxx for a reference to a definition in the current context, and
>   LOCAL_xxx for a reference to a definition in an outer context.

Added a TODO.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/access_semantics.dart:217: * class in which
[identifier] should be looked up.  Null if the expression
On 2015/02/25 12:39:38, karlklose wrote:
> '[Null]' or '`null`'?

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:1593: R visitLazyAnd(
On 2015/02/25 12:39:39, karlklose wrote:
> Why not logical and?

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:1647: /// [receiver] whose
getter and setter are½ defined by [getterSelector] and
On 2015/02/25 12:39:38, karlklose wrote:
> I think they are fully defined!

They are, I've checked ;-)

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2538: /// Postfix
expression with [operator] reading from a static [method], that is,
On 2015/02/25 12:39:39, karlklose wrote:
> long line.

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2613: /// Postfix
expression with [operator] reading from the super field [readField]
On 2015/02/25 12:39:38, karlklose wrote:
> Long line.

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2634: /// Postfix
expression with [operator] reading from a super [field] and writing
On 2015/02/25 12:39:38, karlklose wrote:
> Long line.

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:2715: /// Postfix
expression with [operator] on a type literal for a class [element].
On 2015/02/25 12:39:39, karlklose wrote:
> Long line.

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/send_structure.dart (right):

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/send_structure.dart:15: abstract class
SendStructure<R, A> {
On 2015/02/25 12:39:39, karlklose wrote:
> Please add documentation for this class hierarchy.

Done.

https://codereview.chromium.org/929113002/diff/100001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/send_structure.dart:263: // This is not a valid
case.
On 2015/02/25 12:39:39, karlklose wrote:
> Shouldn't these cases throw too?

No. Compound means that we both a getter and setter target which cannot happen
for an invocation. An expression like `a() = b` would be an assignment with an
erroneous target.

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart (right):

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart:40: Send node,
LocalVariableElement variable, AssignmentOperator operator, Node rhs, A arg) {
Will cleanup long lines while you review.

[Johnni Winther, 2015-03-09 12:50:33]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[Johnni Winther, 2015-03-09 12:50:34]

floitsch@: PTAL (at the last patch)

[karlklose, 2015-03-10 13:57:47]

LGTM when long lines in the generated code are addressed.

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/send_resolver.dart (right):

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/send_resolver.dart:223: case
SendStructureKind.GET:
I think we use 2 space indentation for 'case'.

[Johnni Winther, 2015-03-11 09:14:47]

https://codereview.chromium.org/929113002/diff/100001/tests/compiler/dart2js/...
File tests/compiler/dart2js/semantic_visitor_test.dart (right):

https://codereview.chromium.org/929113002/diff/100001/tests/compiler/dart2js/...
tests/compiler/dart2js/semantic_visitor_test.dart:1979:
visitClassTypeLiteralInvoke(Send node, ClassElement element, NodeList arguments,
Selector selector, arg) {
On 2015/02/20 14:41:15, Johnni Winther wrote:
> Generated long lines. Will Fix.

Done.

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart (right):

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart:40: Send node,
LocalVariableElement variable, AssignmentOperator operator, Node rhs, A arg) {
On 2015/03/04 11:59:39, Johnni Winther wrote:
> Will cleanup long lines while you review.

Done.

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/send_resolver.dart (right):

https://codereview.chromium.org/929113002/diff/140001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/send_resolver.dart:223: case
SendStructureKind.GET:
On 2015/03/10 13:57:46, karlklose wrote:
> I think we use 2 space indentation for 'case'.

Done.

[Johnni Winther, 2015-03-11 09:24:45]

Committed patchset #8 (id:160001) manually as 44393 (presubmit successful).