Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 928663003: Add IsolateRunner as a helper around Isolate. (Closed)

Created:
5 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 10 months ago
Reviewers:
sethladd
Base URL:
https://github.com/dart-lang/isolate.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add IsolateRunner as a helper around Isolate. Add single-message port helpers and a load balancer. R=sethladd@google.com Committed: 2df37dab32a8fb702f094127f053268681d097d1

Patch Set 1 #

Patch Set 2 : Add missing files. #

Patch Set 3 : Also git-add isolate.dart file. #

Patch Set 4 : Add .status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3221 lines, -0 lines) Patch
A .status View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A AUTHORS View 1 1 chunk +6 lines, -0 lines 0 comments Download
A CHANGELOG.md View 1 1 chunk +8 lines, -0 lines 0 comments Download
A CONTRIBUTING.md View 1 1 chunk +33 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +26 lines, -0 lines 0 comments Download
A README.md View 1 chunk +34 lines, -0 lines 0 comments Download
A example/http-server.dart View 1 chunk +119 lines, -0 lines 0 comments Download
A example/runner-pool.dart View 1 chunk +58 lines, -0 lines 0 comments Download
A lib/isolate.dart View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A lib/isolaterunner.dart View 1 chunk +320 lines, -0 lines 0 comments Download
A lib/loadbalancer.dart View 1 chunk +305 lines, -0 lines 0 comments Download
A lib/ports.dart View 1 chunk +269 lines, -0 lines 0 comments Download
A lib/registry.dart View 1 chunk +497 lines, -0 lines 0 comments Download
A lib/runner.dart View 1 chunk +61 lines, -0 lines 0 comments Download
A lib/src/errors.dart View 1 chunk +188 lines, -0 lines 0 comments Download
A lib/src/functionref.dart View 1 chunk +80 lines, -0 lines 0 comments Download
A lib/src/lists.dart View 1 chunk +31 lines, -0 lines 0 comments Download
A lib/src/multiplexport.dart View 1 chunk +103 lines, -0 lines 0 comments Download
A pubspec.yaml View 1 chunk +11 lines, -0 lines 0 comments Download
A test/isolaterunner_test.dart View 1 chunk +114 lines, -0 lines 0 comments Download
A test/ports_test.dart View 1 chunk +394 lines, -0 lines 0 comments Download
A test/registry_test.dart View 1 chunk +539 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Lasse Reichstein Nielsen
This should be following the template and is ready for upload to github.
5 years, 10 months ago (2015-02-23 12:30:06 UTC) #2
sethladd
Hi, Can we add a CONTRIBUTING.md, CHANGELOG.md, and an AUTHORS file. See https://github.com/dart-lang/oss_project_templates/tree/master/dart-github-dart-lang for examples. ...
5 years, 10 months ago (2015-02-23 17:18:25 UTC) #3
sethladd
Hi, Can we add a CONTRIBUTING.md, CHANGELOG.md, and an AUTHORS file. See https://github.com/dart-lang/oss_project_templates/tree/master/dart-github-dart-lang for examples. ...
5 years, 10 months ago (2015-02-23 17:18:30 UTC) #4
Lasse Reichstein Nielsen
Doh. I had the files in the repository, but forgot to "git add" them. PTAL.
5 years, 10 months ago (2015-02-24 08:41:28 UTC) #5
sethladd
lgtm thanks!
5 years, 10 months ago (2015-02-24 16:32:20 UTC) #6
Lasse Reichstein Nielsen
5 years, 10 months ago (2015-02-25 12:00:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
2df37dab32a8fb702f094127f053268681d097d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698