Issue 92863003: Fix stack trace chain tests on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92863003: Fix stack trace chain tests on Windows. (Closed)

Created:
7 years ago by nweiz

Modified:
7 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix stack trace chain tests on Windows. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=30739

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	pkg/stack_trace/test/chain_test.dart	View		5 chunks	+9 lines, -7 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

7 years ago (2013-12-02 22:37:22 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/92863003/diff/1/pkg/stack_trace/test/chain_te...
File pkg/stack_trace/test/chain_test.dart (right):

https://codereview.chromium.org/92863003/diff/1/pkg/stack_trace/test/chain_te...
pkg/stack_trace/test/chain_test.dart:360: '$userSlashCode 10:11  Bang.qux\n'
The fact that this is the exact same number of characters is delightful.

Expand Messages | Collapse Messages