Remove unnecessary state transitions

Remove unnecessary state transitions

R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43789

[Brian Wilkerson, 2015-02-14 17:29:39]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[Brian Wilkerson, 2015-02-14 17:29:39]

In the Java world, one use for IN_PROCESS was to guard against performing the
same task on multiple threads. We don't need to use it that way in Dart.

[scheglov, 2015-02-14 17:34:48]

LGTM

It seems that we don't set IN_PROCESS anymore.
But we still check for it in setState() and _getNextAnalysisTaskForSource().
Why not remove it completely?

[Brian Wilkerson, 2015-02-14 18:07:10]

> It seems that we don't set IN_PROCESS anymore.
> Why not remove it completely?

I thought about that. The other reason it was introduced was to allow for
asynchronous tasks. We originally expected GetContentTask to be async, but it
turns out that synchronous IO is faster. Even so,
(a) there might be environments, such as a browser, where async is required,
(b) we probably need to support 'http:' URI's at some point, which will require
async, and
(c) we might want to allow user-defined tasks to be async.

[Brian Wilkerson, 2015-02-14 18:07:33]

Committed patchset #1 (id:1) manually as 43789 (presubmit successful).