Move the try-catch out of the async-function

Move the try-catch out of the async-function

V8 will not optimize bodies surrounded by try/catch. So it is moved to
js_helper.

To be applied on top of https://codereview.chromium.org/932053002/ .

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43868

[sigurdm, 2015-02-18 11:56:02]

sigurdm@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-18 12:42:45]

LGTM.

https://chromiumcodereview.appspot.com/926553005/diff/1/pkg/compiler/lib/src/...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://chromiumcodereview.appspot.com/926553005/diff/1/pkg/compiler/lib/src/...
pkg/compiler/lib/src/js/rewrite_async.dart:878: while (true)
In a different CL: move the while (true) to the creation of the #helperBody (as
part of it).

https://chromiumcodereview.appspot.com/926553005/diff/1/sdk/lib/_internal/com...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://chromiumcodereview.appspot.com/926553005/diff/1/sdk/lib/_internal/com...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3594: while (true) {
Add comment.
// Invokes [function] with [errorCode] and [result].
//
// If (and as long as) the invocation throws, calls [function] again,
// with an error-code.

https://chromiumcodereview.appspot.com/926553005/diff/1/sdk/lib/_internal/com...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3602: } while (false);
while (false); ?

https://chromiumcodereview.appspot.com/926553005/diff/1/sdk/lib/_internal/com...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3790: while (true) {
ditto.

[sigurdm, 2015-02-18 13:09:04]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[sigurdm, 2015-02-19 09:14:03]

https://codereview.chromium.org/926553005/diff/1/pkg/compiler/lib/src/js/rewr...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/926553005/diff/1/pkg/compiler/lib/src/js/rewr...
pkg/compiler/lib/src/js/rewrite_async.dart:878: while (true)
On 2015/02/18 12:42:45, floitsch wrote:
> In a different CL: move the while (true) to the creation of the #helperBody
(as
> part of it).

Acknowledged.

https://codereview.chromium.org/926553005/diff/1/sdk/lib/_internal/compiler/j...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/926553005/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3594: while (true) {
On 2015/02/18 12:42:45, floitsch wrote:
> Add comment.
> // Invokes [function] with [errorCode] and [result].
> //
> // If (and as long as) the invocation throws, calls [function] again,
> // with an error-code.

Done.

https://codereview.chromium.org/926553005/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3602: } while (false);
On 2015/02/18 12:42:45, floitsch wrote:
> while (false); ?

I started out with 
do {
  try {
  ....
  } catch
  ...
  continue;
  }
} while(false);
Before I realized the condition is reevaluated on continue.
Then I forgot to remove the while false...

Done.

https://codereview.chromium.org/926553005/diff/1/sdk/lib/_internal/compiler/j...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3790: while (true) {
On 2015/02/18 12:42:45, floitsch wrote:
> ditto.

Done.

[sigurdm, 2015-02-19 09:21:18]

Committed patchset #3 (id:40001) manually as 43868 (presubmit successful).

[sra1, 2015-02-19 20:55:01]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2015-02-19 20:55:02]

DBC.

It is good to see smaller code for common cases.

Try to use js_ast templates more than direct allocation calls.  I'd like the
js_ast to be almost completely abstract, e.g. there is no need to know that This
is a different representation to a variable reference.
If you find something is missing from js_ast library, lets discuss it.

https://chromiumcodereview.appspot.com/926553005/diff/40001/pkg/compiler/lib/...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://chromiumcodereview.appspot.com/926553005/diff/40001/pkg/compiler/lib/...
pkg/compiler/lib/src/js/rewrite_async.dart:844: new js.Call(newController, [new
js.VariableUse(bodyName)])));
new js.Call...  ->   js('#(#)', [newController, bodyName]))

https://chromiumcodereview.appspot.com/926553005/diff/40001/pkg/compiler/lib/...
pkg/compiler/lib/src/js/rewrite_async.dart:857: inits.add(makeInit(selfName, new
js.This()));
new js.This()  -->  js('this')

https://chromiumcodereview.appspot.com/926553005/diff/40001/pkg/compiler/lib/...
pkg/compiler/lib/src/js/rewrite_async.dart:874: if (#errorCode == #ERROR) {
== --> ===

https://chromiumcodereview.appspot.com/926553005/diff/40001/pkg/compiler/lib/...
pkg/compiler/lib/src/js/rewrite_async.dart:1109: condition,
js.number(thenLabel), js.number(elseLabel))));
js.statement('# = # ? # : #',
  gotoName, condition, js.number(thenLabel), js.number(elseLabel));

[sigurdm, 2015-02-23 14:58:37]

Thanks - I address the comments in: https://codereview.chromium.org/946353003

https://codereview.chromium.org/926553005/diff/40001/pkg/compiler/lib/src/js/...
File pkg/compiler/lib/src/js/rewrite_async.dart (right):

https://codereview.chromium.org/926553005/diff/40001/pkg/compiler/lib/src/js/...
pkg/compiler/lib/src/js/rewrite_async.dart:844: new js.Call(newController, [new
js.VariableUse(bodyName)])));
On 2015/02/19 20:55:02, sra1 wrote:
> new js.Call...  ->   js('#(#)', [newController, bodyName]))

Done.

https://codereview.chromium.org/926553005/diff/40001/pkg/compiler/lib/src/js/...
pkg/compiler/lib/src/js/rewrite_async.dart:857: inits.add(makeInit(selfName, new
js.This()));
On 2015/02/19 20:55:02, sra1 wrote:
> new js.This()  -->  js('this')

Done.

https://codereview.chromium.org/926553005/diff/40001/pkg/compiler/lib/src/js/...
pkg/compiler/lib/src/js/rewrite_async.dart:874: if (#errorCode == #ERROR) {
On 2015/02/19 20:55:02, sra1 wrote:
> == --> ===

Done.

https://codereview.chromium.org/926553005/diff/40001/pkg/compiler/lib/src/js/...
pkg/compiler/lib/src/js/rewrite_async.dart:1109: condition,
js.number(thenLabel), js.number(elseLabel))));
On 2015/02/19 20:55:02, sra1 wrote:
> js.statement('# = # ? # : #',
>   gotoName, condition, js.number(thenLabel), js.number(elseLabel));

Done.

[sra1, 2015-02-27 20:34:51]

DBC

https://codereview.chromium.org/926553005/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/926553005/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3790: runBody() {
Make this private, otherwise I can call it from user code.

I also see that dart2js inlined the code into moveNext.
That does not seem to do any harm, but if you want to prevent that, use
@NoInline().

[sigurdm, 2015-03-02 09:14:47]

https://codereview.chromium.org/926553005/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/js_lib/js_helper.dart (right):

https://codereview.chromium.org/926553005/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/js_lib/js_helper.dart:3790: runBody() {
On 2015/02/27 20:34:51, sra1 wrote:
> Make this private, otherwise I can call it from user code.
> 
Good point. Thanks

> I also see that dart2js inlined the code into moveNext.
> That does not seem to do any harm, but if you want to prevent that, use
> @NoInline().