Fix crash that happens when we send an object whose type is in a defer

Fix crash that happens when we send an object whose type is in a defer
loaded a library that is loaded in the isolate that is sending the message but has not been loaded yet in the isolate which is receiving the message.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43774

[siva, 2015-02-13 17:43:45]

asiva@google.com changed reviewers:
+ hausner@google.com

[hausner, 2015-02-13 18:05:49]

LGTM with commments.

https://chromiumcodereview.appspot.com/926073002/diff/20001/runtime/vm/snapsh...
File runtime/vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/926073002/diff/20001/runtime/vm/snapsh...
runtime/vm/snapshot.cc:255: void SnapshotReader::SetReadException(const char*
msg) {
I don't understand why the function is called SetXXXX. Doesn't it throw an
exception?

https://chromiumcodereview.appspot.com/926073002/diff/20001/tests/isolate/iss...
File tests/isolate/issue_21398_parent_isolate2_test.dart (right):

https://chromiumcodereview.appspot.com/926073002/diff/20001/tests/isolate/iss...
tests/isolate/issue_21398_parent_isolate2_test.dart:11: // In this test case we
send an object created from a defer loaded library
So far we've used the term "deferred library" for this.

https://chromiumcodereview.appspot.com/926073002/diff/20001/tests/isolate/iss...
tests/isolate/issue_21398_parent_isolate2_test.dart:34: Expect.equals(1, 0);
Use Expect.fail("should not receive a valid message here");

[siva, 2015-02-13 18:43:13]

New patchsets have been uploaded after l-g-t-m from hausner@google.com

[siva, 2015-02-13 18:43:42]

https://chromiumcodereview.appspot.com/926073002/diff/20001/runtime/vm/snapsh...
File runtime/vm/snapshot.cc (right):

https://chromiumcodereview.appspot.com/926073002/diff/20001/runtime/vm/snapsh...
runtime/vm/snapshot.cc:255: void SnapshotReader::SetReadException(const char*
msg) {
On 2015/02/13 18:05:49, hausner wrote:
> I don't understand why the function is called SetXXXX. Doesn't it throw an
> exception?

It does not throw an exception here, it does a longjump here which then results
in an error object being created by the snapshot reader. The error object is
returned, the isolate message handler then processes the unhandled exception.

https://chromiumcodereview.appspot.com/926073002/diff/20001/tests/isolate/iss...
File tests/isolate/issue_21398_parent_isolate2_test.dart (right):

https://chromiumcodereview.appspot.com/926073002/diff/20001/tests/isolate/iss...
tests/isolate/issue_21398_parent_isolate2_test.dart:11: // In this test case we
send an object created from a defer loaded library
On 2015/02/13 18:05:49, hausner wrote:
> So far we've used the term "deferred library" for this.

Done.

https://chromiumcodereview.appspot.com/926073002/diff/20001/tests/isolate/iss...
tests/isolate/issue_21398_parent_isolate2_test.dart:34: Expect.equals(1, 0);
On 2015/02/13 18:05:49, hausner wrote:
> Use Expect.fail("should not receive a valid message here");

Done.

[siva, 2015-02-13 19:17:08]

Committed patchset #3 (id:40001) manually as r43774 (presubmit successful).

[ahe, 2017-04-06 15:38:17]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-04-06 15:38:19]

https://codereview.chromium.org/926073002/diff/40001/tests/isolate/issue_2139...
File tests/isolate/issue_21398_parent_isolate2_test.dart (right):

https://codereview.chromium.org/926073002/diff/40001/tests/isolate/issue_2139...
tests/isolate/issue_21398_parent_isolate2_test.dart:48: helperFunction(); ///
01: runtime error
Why is this a multi-test?

[siva, 2017-04-06 18:15:42]

https://codereview.chromium.org/926073002/diff/40001/tests/isolate/issue_2139...
File tests/isolate/issue_21398_parent_isolate2_test.dart (right):

https://codereview.chromium.org/926073002/diff/40001/tests/isolate/issue_2139...
tests/isolate/issue_21398_parent_isolate2_test.dart:48: helperFunction(); ///
01: runtime error
On 2017/04/06 15:38:18, ahe wrote:
> Why is this a multi-test?

It doesn't have to be, I think I did this way so it was not necessary to add a
line in the status file stating a RuntimeError is expected.

[ahe, 2017-04-07 06:14:18]

https://codereview.chromium.org/926073002/diff/40001/tests/isolate/issue_2139...
File tests/isolate/issue_21398_parent_isolate2_test.dart (right):

https://codereview.chromium.org/926073002/diff/40001/tests/isolate/issue_2139...
tests/isolate/issue_21398_parent_isolate2_test.dart:48: helperFunction(); ///
01: runtime error
On 2017/04/06 18:15:42, siva wrote:
> On 2017/04/06 15:38:18, ahe wrote:
> > Why is this a multi-test?
> 
> It doesn't have to be, I think I did this way so it was not necessary to add a
> line in the status file stating a RuntimeError is expected.

Which runtime error is expected, the one one line 33, line 39, or something
different?