Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 926063003: pkg/unittest: use matcher from github at master (Closed)

Created:
5 years, 10 months ago by kevmoo
Modified:
5 years, 10 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/unittest.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : cl comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pubspec.yaml View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
kevmoo
5 years, 10 months ago (2015-02-17 20:18:44 UTC) #2
nweiz
https://codereview.chromium.org/926063003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/926063003/diff/1/pubspec.yaml#newcode9 pubspec.yaml:9: # Using the pre-release version of matcher Can you ...
5 years, 10 months ago (2015-02-17 20:51:29 UTC) #3
kevmoo
https://codereview.chromium.org/926063003/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/926063003/diff/1/pubspec.yaml#newcode9 pubspec.yaml:9: # Using the pre-release version of matcher On 2015/02/17 ...
5 years, 10 months ago (2015-02-17 20:54:40 UTC) #4
nweiz
lgtm
5 years, 10 months ago (2015-02-17 20:56:03 UTC) #5
kevmoo
5 years, 10 months ago (2015-02-17 20:56:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
7acb71ce954829b6149ed0e257eb9278e2875f11 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698