Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 925943002: Refactor SourceFile, SourceFileProvider and SourceLocation. (Closed)

Created:
5 years, 10 months ago by Johnni Winther
Modified:
5 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor SourceFile, SourceFileProvider and SourceLocation. Main changes in: pkg/compiler/lib/src/io/source_file.dart pkg/compiler/lib/src/io/source_information.dart pkg/compiler/lib/src/source_file_provider.dart BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=43756

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -122 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/code_output.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/io/source_file.dart View 4 chunks +19 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 2 chunks +39 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/io/source_map_builder.dart View 1 7 chunks +45 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 4 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/dart2js_incremental/lib/library_updater.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/dart2js_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/dart2js_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/dart_printer_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/memory_source_file_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/source_mapping_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/type_checker_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/warnings_checker.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
5 years, 10 months ago (2015-02-13 12:50:21 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/925943002/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/925943002/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode173 pkg/compiler/lib/src/dart2js.dart:173: var filenames = new List.from(sourceFiles.keys.map((uri) => '$uri')); since ...
5 years, 10 months ago (2015-02-13 13:46:04 UTC) #3
Johnni Winther
https://codereview.chromium.org/925943002/diff/1/pkg/compiler/lib/src/dart2js.dart File pkg/compiler/lib/src/dart2js.dart (right): https://codereview.chromium.org/925943002/diff/1/pkg/compiler/lib/src/dart2js.dart#newcode173 pkg/compiler/lib/src/dart2js.dart:173: var filenames = new List.from(sourceFiles.keys.map((uri) => '$uri')); On 2015/02/13 ...
5 years, 10 months ago (2015-02-13 13:55:49 UTC) #5
Johnni Winther
5 years, 10 months ago (2015-02-13 14:03:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 43756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698