Add the shared flag to HttpServer as well

Add the shared flag to HttpServer as well

Also mark the ServerSocketReference and friends as deprecated and to
be removed in Dart 1.10

R=kustermann@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=43809

[kustermann, 2015-02-17 11:30:56]

lgtm with comments

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart#newcode241
sdk/lib/io/http.dart:241: * additional binds are preformed, then the incoming
(incoming)
preformed -> performed

remove "(incoming)"?

- also below

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart#newcode242
sdk/lib/io/http.dart:242: * connections will be distributed between that set
that set -> that set of

- also below

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart#newcode245
sdk/lib/io/http.dart:245: */
Maybe also describe [v6Only] - also below

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/secure_server_soc...
File sdk/lib/io/secure_server_socket.dart (right):

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/secure_server_soc...
sdk/lib/io/secure_server_socket.dart:68: * isolates between which incoming
connections are distributed.
preformed -> performed
remove "(incoming)"

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:230: * additional binds are preformed, then the incoming
(accepted)
preformed -> performed

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:274: 'Use the `shared` optional argument on the `bind`
method instead.')
long line.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:335: * additional binds are preformed, then the incoming
(incoming)
ditto

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:378: 'Use the `shared` optional argument on the `bind`
method instead.')
long line

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
File tests/standalone/io/http_bind_test.dart (right):

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:20: var response = await
request.close();
Maybe use a specific status code, to ensure we got a correct response?

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:38: await request.response.close();
You could remove the "async " and "await" here, since the return '.listen()'
expects a callback which returns void IIRC.

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:46: await request.response.close();
ditto

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:61: testBindShared(host, true);
This translates to

1  testBindShared('127.0.0.1', v6Only=false);
2  testBindShared('127.0.0.1', v6Only=true);
2  testBindShared('::1', v6Only=false);
3  testBindShared('::1', v6Only=true);

What is the behavior of line 2 -- i.e. 127.0.0.1+v6Only=true ?

[Søren Gjesse, 2015-02-17 12:53:12]

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart#newcode241
sdk/lib/io/http.dart:241: * additional binds are preformed, then the incoming
(incoming)
On 2015/02/17 11:30:55, kustermann wrote:
> preformed -> performed
> 
> remove "(incoming)"?
> 
> - also below

Done.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart#newcode242
sdk/lib/io/http.dart:242: * connections will be distributed between that set
On 2015/02/17 11:30:56, kustermann wrote:
> that set -> that set of
> 
> - also below

Done.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/http.dart#newcode245
sdk/lib/io/http.dart:245: */
On 2015/02/17 11:30:56, kustermann wrote:
> Maybe also describe [v6Only] - also below

Done.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/secure_server_soc...
File sdk/lib/io/secure_server_socket.dart (right):

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/secure_server_soc...
sdk/lib/io/secure_server_socket.dart:68: * isolates between which incoming
connections are distributed.
On 2015/02/17 11:30:56, kustermann wrote:
> preformed -> performed
> remove "(incoming)"

Done.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:230: * additional binds are preformed, then the incoming
(accepted)
On 2015/02/17 11:30:56, kustermann wrote:
> preformed -> performed

Done.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:274: 'Use the `shared` optional argument on the `bind`
method instead.')
On 2015/02/17 11:30:56, kustermann wrote:
> long line.

Done.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:335: * additional binds are preformed, then the incoming
(incoming)
On 2015/02/17 11:30:56, kustermann wrote:
> ditto

Done.

https://codereview.chromium.org/925403002/diff/1/sdk/lib/io/socket.dart#newco...
sdk/lib/io/socket.dart:378: 'Use the `shared` optional argument on the `bind`
method instead.')
On 2015/02/17 11:30:56, kustermann wrote:
> long line

Done.

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
File tests/standalone/io/http_bind_test.dart (right):

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:20: var response = await
request.close();
On 2015/02/17 11:30:56, kustermann wrote:
> Maybe use a specific status code, to ensure we got a correct response?

Done.

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:38: await request.response.close();
On 2015/02/17 11:30:56, kustermann wrote:
> You could remove the "async " and "await" here, since the return '.listen()'
> expects a callback which returns void IIRC.

Done.

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:46: await request.response.close();
On 2015/02/17 11:30:56, kustermann wrote:
> ditto

Done.

https://codereview.chromium.org/925403002/diff/1/tests/standalone/io/http_bin...
tests/standalone/io/http_bind_test.dart:61: testBindShared(host, true);
On 2015/02/17 11:30:56, kustermann wrote:
> This translates to
> 
> 1  testBindShared('127.0.0.1', v6Only=false);
> 2  testBindShared('127.0.0.1', v6Only=true);
> 2  testBindShared('::1', v6Only=false);
> 3  testBindShared('::1', v6Only=true);
> 
> What is the behavior of line 2 -- i.e. 127.0.0.1+v6Only=true ?

In that case v6Only is ignored. Not sure that is the expected behaviour. Opened
http://dartbug.com/22451.

[Søren Gjesse, 2015-02-17 13:17:11]

Committed patchset #1 (id:1) manually as 43809 (presubmit successful).