Issue 92513002: Switch SetupIsolateForProfiling to use calloc instead of new []

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 92513002: Switch SetupIsolateForProfiling to use calloc instead of new [] (Closed)

Created:
7 years ago by Cutch

Modified:
7 years ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Switch SetupIsolateForProfiling to use calloc instead of new [] BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30733

Patch Set 2 : #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -2 lines)			Patch
	M	runtime/vm/profiler.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/92513002/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/92513002/diff/1/runtime/vm/profiler.cc#newcode590 runtime/vm/profiler.cc:590: } for completeness: start_ = 0; end_ = ...

7 years ago (2013-11-27 21:01:54 UTC) #2

Cutch

https://codereview.chromium.org/92513002/diff/1/runtime/vm/profiler.cc File runtime/vm/profiler.cc (right): https://codereview.chromium.org/92513002/diff/1/runtime/vm/profiler.cc#newcode590 runtime/vm/profiler.cc:590: } On 2013/11/27 21:01:55, siva wrote: > for completeness: ...

7 years ago (2013-11-27 21:48:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30733 (presubmit successful).

Expand Messages | Collapse Messages

Issue 92513002: Switch SetupIsolateForProfiling to use calloc instead of new [] (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages