Minor changes in analyzer to make it easier to extend

Minor changes in analyzer to make it easier to extend

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43934

[Siggi Cherem (dart-lang), 2015-02-20 21:22:08]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-02-20 21:24:30]

sigmund@google.com changed reviewers:
+ brianwilkerson@google.com

[Siggi Cherem (dart-lang), 2015-02-20 21:24:30]

A couple questions I wasn't sure about: 
- what's the typical way you test things out before submitting? So far I only
ran:

  ./tools/test.py -m release pkg/analyzer

- is it ok to bump the pubspec/release right away?

[Brian Wilkerson, 2015-02-20 21:39:07]

LGTM

> what's the typical way you test things out before submitting?

I usually run the full test suite:
$ ./tools/test.py --mode release --compiler dart2analyzer --runtime none
--progress color --report --tasks=2

- is it ok to bump the pubspec/release right away?

Yes, I we're OK with that.

https://codereview.chromium.org/924943010/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/924943010/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/resolver.dart:8312: var
typeResolverVisitorFactory =
We provide type annotations everywhere, so please replace all uses of 'var' ...

https://codereview.chromium.org/924943010/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/resolver.dart:10465: {StaticTypeAnalyzer
typeAnalyzer, typeAnalyzerFactory})
... and annotate all parameters.

[Siggi Cherem (dart-lang), 2015-02-20 21:47:44]

New patchsets have been uploaded after l-g-t-m from brianwilkerson@google.com

[Siggi Cherem (dart-lang), 2015-02-20 22:12:47]

> I usually run the full test suite:
> $ ./tools/test.py --mode release --compiler dart2analyzer --runtime none
> --progress color --report --tasks=2

nice - I caught a couple test failures this way. I needed to add the API to the
InternalAnalysisContext interface and to the engine_test.dart

> 
> - is it ok to bump the pubspec/release right away?
> 
> Yes, I we're OK with that.

awesome

[Siggi Cherem (dart-lang), 2015-02-20 22:12:59]

PTAL

https://codereview.chromium.org/924943010/diff/20001/pkg/analyzer/lib/src/gen...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/924943010/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/resolver.dart:8312: var
typeResolverVisitorFactory =
On 2015/02/20 21:39:07, Brian Wilkerson wrote:
> We provide type annotations everywhere, so please replace all uses of 'var'
...

Done.

https://codereview.chromium.org/924943010/diff/20001/pkg/analyzer/lib/src/gen...
pkg/analyzer/lib/src/generated/resolver.dart:10465: {StaticTypeAnalyzer
typeAnalyzer, typeAnalyzerFactory})
On 2015/02/20 21:39:07, Brian Wilkerson wrote:
> ... and annotate all parameters.

Done.

[Brian Wilkerson, 2015-02-20 22:14:22]

Still LGTM

[Siggi Cherem (dart-lang), 2015-02-20 22:23:34]

Committed patchset #3 (id:60001) manually as 43934 (presubmit successful).