Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 924793002: Add SkipSlow marker (Closed)

Created:
5 years, 10 months ago by ricow1
Modified:
5 years, 10 months ago
Reviewers:
Bill Hesse, kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add SkipSlow marker This is to be used temporarily until we can start running slow tests on seperate bots. R=whesse@google.com, kevmoo@google.com BUG=22402 Committed: https://code.google.com/p/dart/source/detail?r=43751

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M tests/language/assert_with_type_test_or_cast_test.dart View 2 chunks +5 lines, -5 lines 1 comment Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tools/testing/dart/summary_report.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
https://codereview.chromium.org/924793002/diff/20001/tests/language/assert_with_type_test_or_cast_test.dart File tests/language/assert_with_type_test_or_cast_test.dart (right): https://codereview.chromium.org/924793002/diff/20001/tests/language/assert_with_type_test_or_cast_test.dart#newcode6 tests/language/assert_with_type_test_or_cast_test.dart:6: // when run in production mode. This is unrelated ...
5 years, 10 months ago (2015-02-13 07:56:27 UTC) #1
Bill Hesse
lgtm
5 years, 10 months ago (2015-02-13 09:44:08 UTC) #2
ricow1
5 years, 10 months ago (2015-02-13 10:02:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 43751 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698