Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 924783004: Mark test as failing. (Closed)

Created:
5 years, 10 months ago by karlklose
Modified:
5 years, 10 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/lib/analyzer/analyze_library.status View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 10 months ago (2015-02-13 14:32:54 UTC) #1
sigurdm
LGTM https://codereview.chromium.org/924783004/diff/1/tests/lib/analyzer/analyze_library.status File tests/lib/analyzer/analyze_library.status (right): https://codereview.chromium.org/924783004/diff/1/tests/lib/analyzer/analyze_library.status#newcode28 tests/lib/analyzer/analyze_library.status:28: lib/async/async: CompileTimeError # Issue 22415 Perhaps CC someone ...
5 years, 10 months ago (2015-02-13 14:49:01 UTC) #2
karlklose
5 years, 10 months ago (2015-02-13 14:58:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 43761 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698