Issue 924563002: Flush entries for unreferenced sources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 924563002: Flush entries for unreferenced sources (Closed)

Created:
5 years, 10 months ago by Brian Wilkerson

Modified:
5 years, 10 months ago

Reviewers:
Paul Berry, scheglov

CC:
reviews_dartlang.org, Paul Berry

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Flush entries for unreferenced sources R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=43730

Patch Set 1 #

Patch Set 2 : Clean up #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -14 lines)			Patch
	M	pkg/analyzer/lib/src/generated/engine.dart	View	1	4 chunks	+23 lines, -13 lines	0 comments	Download
	M	pkg/analyzer/test/generated/engine_test.dart	View	1	2 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

Committed patchset #2 (id:20001) manually as 43730 (presubmit successful).

5 years, 10 months ago (2015-02-12 17:50:52 UTC) #4

Paul Berry

5 years, 10 months ago (2015-02-12 18:28:39 UTC) #6

Message was sent while issue was closed.

lgtm.

It would be nice to have a test for this functionality.

Also, am I correct in understanding that this won't collect cycles?  If so, we
should probably put a comment in the code to document that.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages