Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 923803002: Fix even more status file stuff. (Closed)

Created:
5 years, 10 months ago by nweiz
Modified:
5 years, 10 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/unittest@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix even more status file stuff. Remove the "build/" prefix from a bunch of status lines, add a missing import to test/io.dart, and use SkipByDesign everywhere. R=kevmoo@google.com Committed: https://github.com/dart-lang/unittest/commit/739503eef6417836c8b406492b7f19e855115e0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -46 lines) Patch
M .status View 2 chunks +46 lines, -46 lines 0 comments Download
M test/io.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 10 months ago (2015-02-13 00:49:29 UTC) #1
kevmoo
lgtm
5 years, 10 months ago (2015-02-13 00:50:44 UTC) #2
nweiz
5 years, 10 months ago (2015-02-13 01:03:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
739503eef6417836c8b406492b7f19e855115e0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698