Issue 20050. Show corrections for errors.

Issue 20050. Show corrections for errors.

R=brianwilkerson@google.com, danrubel@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=20050

Committed: https://code.google.com/p/dart/source/detail?r=43736

[Brian Wilkerson, 2015-02-12 19:09:33]

LGTM

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java
(right):

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java:40:
"Consider using 'as prefix' for one of the import directives."),
Or hiding the name from all but one of the imports.

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java
(right):

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java:208:
return marker.getAttribute(DartCore.MARKER_ATTR_CORRECTION, null);
If the attribute doesn't exist, should we return "super.getText(element)"
instead?

https://codereview.chromium.org/923623002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/923623002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/error.dart:3810: "Consider using 'as prefix' for
one of the import directives.");
Same as before: Or hiding the name from all but one of the imports.

[scheglov, 2015-02-12 19:16:32]

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java
(right):

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticWarningCode.java:40:
"Consider using 'as prefix' for one of the import directives."),
On 2015/02/12 19:09:33, Brian Wilkerson wrote:
> Or hiding the name from all but one of the imports.

Done.

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java
(right):

https://codereview.chromium.org/923623002/diff/1/editor/tools/plugins/com.goo...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/problemsview/ProblemsView.java:208:
return marker.getAttribute(DartCore.MARKER_ATTR_CORRECTION, null);
On 2015/02/12 19:09:33, Brian Wilkerson wrote:
> If the attribute doesn't exist, should we return "super.getText(element)"
> instead?

It is OK to return null.
We don't want to show anything as a correction, if input is not a marker.

https://codereview.chromium.org/923623002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/error.dart (right):

https://codereview.chromium.org/923623002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/error.dart:3810: "Consider using 'as prefix' for
one of the import directives.");
On 2015/02/12 19:09:33, Brian Wilkerson wrote:
> Same as before: Or hiding the name from all but one of the imports.

Done.

[scheglov, 2015-02-12 19:17:24]

Committed patchset #1 (id:1) manually as 43736 (presubmit successful).