dart2js: add special getter to Closure class in new emitter.

dart2js: add special getter to Closure class in new emitter.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=43753

[zarah, 2015-02-12 10:10:05]

zarah@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-02-12 12:22:15]

An alternative approach would be to install a get call on the Closure class and
just treat it specially in a few other parts in the compiler.
I hacked together a version in:
https://codereview.chromium.org/920763002/

(I removed a check that we would need to adjust similar to the one where we
decide if the getter needs call stubs or not).

Wdyt?

[zarah, 2015-02-12 13:03:29]

It's a hack either way. As we talked about, I like the idea of having it
directly in the Closure class but on the other hand the hack is more spread out
which makes it more complicated, so I prefer the first solution.

[floitsch, 2015-02-13 12:38:28]

ok. Then let's go with this approach.

LGTM.

https://codereview.chromium.org/923463002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/923463002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:364: ClassElement
implementation = element.implementation;
New line before.

[zarah, 2015-02-13 12:51:53]

New patchsets have been uploaded after l-g-t-m from floitsch@google.com

[zarah, 2015-02-13 12:52:18]

https://codereview.chromium.org/923463002/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/program_builder.dart (right):

https://codereview.chromium.org/923463002/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/program_builder.dart:364: ClassElement
implementation = element.implementation;
On 2015/02/13 12:38:28, floitsch wrote:
> New line before.

Done.

[zarah, 2015-02-13 13:03:09]

Committed patchset #2 (id:20001) manually as 43753 (presubmit successful).