Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 923103003: Avoid spurious "The compiler crashed" messages in batch mode. (Closed)

Created:
5 years, 10 months ago by floitsch
Modified:
5 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, ahe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid spurious "The compiler crashed" messages in batch mode. BUG= http://dartbug.com/21926 R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=43799

Patch Set 1 #

Patch Set 2 : Remove spurious debug print. #

Total comments: 2

Patch Set 3 : Fix indentation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -21 lines) Patch
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js/dart2js_batch2_run.dart View 1 chunk +5 lines, -1 line 0 comments Download
A + tests/compiler/dart2js/dart2js_batch2_test.dart View 1 2 2 chunks +6 lines, -18 lines 0 comments Download
M tests/compiler/dart2js/dart2js_batch_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
5 years, 10 months ago (2015-02-13 18:25:06 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/923103003/diff/20001/tests/compiler/dart2js/dart2js_batch2_test.dart File tests/compiler/dart2js/dart2js_batch2_test.dart (right): https://codereview.chromium.org/923103003/diff/20001/tests/compiler/dart2js/dart2js_batch2_test.dart#newcode42 tests/compiler/dart2js/dart2js_batch2_test.dart:42: new File(Platform.script.resolve("dart2js_batch2_run.dart").path); Indent by 4.
5 years, 10 months ago (2015-02-16 11:13:33 UTC) #3
floitsch
https://codereview.chromium.org/923103003/diff/20001/tests/compiler/dart2js/dart2js_batch2_test.dart File tests/compiler/dart2js/dart2js_batch2_test.dart (right): https://codereview.chromium.org/923103003/diff/20001/tests/compiler/dart2js/dart2js_batch2_test.dart#newcode42 tests/compiler/dart2js/dart2js_batch2_test.dart:42: new File(Platform.script.resolve("dart2js_batch2_run.dart").path); On 2015/02/16 11:13:32, Johnni Winther wrote: > ...
5 years, 10 months ago (2015-02-16 11:52:22 UTC) #5
floitsch
5 years, 10 months ago (2015-02-16 11:52:37 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 43799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698